Fixes #11616 - Adding job invocation api controller #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
jlsherrill
force-pushed
the
controller4
branch
3 times, most recently
from
f5d580d
to
e7d3aac
Compare
| process_response @composer.save! | ||
| end | ||
|
|
||
| def resource_name |
There was a problem hiding this comment.
is this needed? the controller name seems standard
jlsherrill
force-pushed
the
controller4
branch
from
e7d3aac
to
106fbb3
Compare
jlsherrill
force-pushed
the
controller4
branch
from
106fbb3
to
830578e
Compare
theforeman-bot
added
Needs testing
Waiting on contributor
and removed
Waiting on contributor
labels
jlsherrill
force-pushed
the
controller4
branch
from
830578e
to
9233fc3
Compare
jlsherrill
changed the title
jlsherrill
force-pushed
the
controller4
branch
2 times, most recently
from
307c968
to
4a3b055
Compare
| @@ -0,0 +1,3 @@ | |||
| collection @job_templates | |||
There was a problem hiding this comment.
@job_invocations, unfortunately functional tests don't cover this
jlsherrill
force-pushed
the
controller4
branch
from
4a3b055
to
9dfaa51
Compare
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
rebase wanted |
jlsherrill
force-pushed
the
controller4
branch
2 times, most recently
from
5c0d58b
to
854a12f
Compare
|
rebased! |
jlsherrill
force-pushed
the
controller4
branch
from
854a12f
to
da4bb05
Compare
|
rebased again |
|
[test] |
|
Tested again, works nicely, ACK => merge at will |
|
We agreed with @iNecas that there's no need to wait for author to merge his own PR after it's ACKed, so I'm merging this one. Thanks @jlsherrill! |
ares
added a commit
that referenced
this pull request
Sep 29, 2015
Fixes #11616 - Adding job invocation api controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.