Fixes #14684 - Save end time for recurring

[adamruzicka]

• Requires Refs #14684 - Triggering validation foreman-tasks#183

[ares]

It does not seem to work for me, when I set end time, the action results in 200 but it redirects me back to the invocation form without any error. Also it creates the job, it creates recurring action but it does not create the task so the job is queued forever. I don't see any error in the log.

[ares]

After short debugging session we realized that if there's no window for job to start, task is not created causing all of this problems. So a validation should be added that checks that $start_time < $end_time

[adamruzicka]

[test]

[ares]

since you're already touching this line, would you mind changing

!pattern_template_invocations.map(&:valid?).include?(false)
to
pattern_template_invocations.all?(&:valid?)

[ares]

Tested manually and works fine, except one possible improvement in code this patch touches it's good to merge. Well after we have tests fixed and jenkins will confirm.

[adamruzicka]

Wasn't there a specific need for doing it this way? Something like it was needed to force validation of all of the template invocations (which the all? approach wouldn't do)?

[ares]

ah right, .all? is lazy 💡 thanks!

[adamruzicka]

Great, glad we didn't miss it

[iNecas]

Foreman-tasks 0.7.17 with required change was just released

[adamruzicka]

Let's see how the [test] goes

[adamruzicka]

[test]

[adamruzicka]

[test]

[ares]

Works fine, thanks @adamruzicka, merging!

[ares]

oops I left double comment in commit message, sorry :-)