Refs #14842 - 'validate' should be 'validates' #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| require 'dynflow/testing' | ||
| require 'database_cleaner' |
There was a problem hiding this comment.
I also took the ocassion to fix this. If you're running tests individually (not with rake test), these tests will not work because of DatabaseCleaner in line 11. This is only loaded on integration tests now in core , so we have to require it manually.
|
My commit had the database cleaner patch, it's in https://github.com/theforeman/foreman_remote_execution/pull/173/files#diff-b7be47364acf6629bcdcf5d0ab5f9ffbR3 The unit tests are valuable though. |
stbenjam
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
Updated 😄 |
ares
changed the title
|
Thanks @dLobatog, merging! |
MariaAga
pushed a commit
to MariaAga/foreman_remote_execution
that referenced
this pull request
Sep 3, 2021
…d-delayed Fixes #13833 - Handle humanized input with delayed task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On remote_execution_feature, there's a line calling
validateand thencalls some Rails validations. It has a typo and should say
validates.Passenger does not start because of this, with an error
' Message from application: Unknown key: :presence. Valid keys are: :on,
:if, :unless, :prepend. Perhaps you meant to call
validatesinsteadof
validate? (ArgumentError) 'Fix is as simple as correcting the typo.