Fixes #16002 - convert to strong params #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
iNecas
commented
Aug 11, 2016
•
iNecas
commented
- - requires Fixes #16065 - convert to strong params foreman-tasks#195
|
ack for db:migrate working. i did not try functionality |
|
All kinds of job invocations work as expected, ACK PS: I encoutered an odd issue while testing this, but I don't think it's related |
|
Tests are green http://ci.theforeman.org/job/test_plugin_pull_request/2806/, merging, thanks for testing and review @thomasmckay @adamruzicka |
MariaAga
pushed a commit
to MariaAga/foreman_remote_execution
that referenced
this pull request
Sep 3, 2021
* Fixes #16113 - Display tasks in planning state properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.