Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #19920 - Remove job invocations when deleting tasks #255

Merged
merged 3 commits into from Jul 10, 2017

Conversation

adamruzicka
Copy link
Contributor

No description provided.

@iNecas
Copy link
Member

iNecas commented Jun 19, 2017

This approach actually doesn't work, as the task cleanup does the deletion in bulk: bypassing the dependent destroy flags.

What do you think about turning the job into "archived" mode, where we would still have a notion, that the task was completed, but we don't have the full data: this would also let the user to get the data back if needed, using the backup of tasks, that is going to be added sooner or later?

Alternatively, we would need to enhance the tasks:cleanup task to remove the jobs that were orphaned by the task cleanup (I expect we could use the standard destroy there, as the amount of job invocations should be lower by order of magnitude to the amount of tasks in the system). But I would probably still prefer the archived state here, and handle the full deletion of the job invocation in separate issue.

@iNecas
Copy link
Member

iNecas commented Jul 10, 2017

Thanks @adamruzicka

@adamruzicka adamruzicka deleted the cleanup branch July 10, 2017 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants