Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #22395 - Added DEFAULT_REFRESH_INTERVAL constant #305

Merged
merged 1 commit into from Feb 6, 2018
Merged

Fixes #22395 - Added DEFAULT_REFRESH_INTERVAL constant #305

merged 1 commit into from Feb 6, 2018

Conversation

dmitri-d
Copy link
Member

No description provided.

adamruzicka
adamruzicka approved these changes Feb 5, 2018
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

adamruzicka
adamruzicka reviewed Feb 5, 2018
View reviewed changes
lib/foreman_remote_execution_core/fake_script_runner.rb Outdated
@@ -1,6 +1,7 @@
module ForemanRemoteExecutionCore
class FakeScriptRunner < ForemanTasksCore::Runner::Base

DEFAULT_REFRESH_INTERVAL = 60
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the FakeScriptRunner use the same default interval as a regular ScriptRunner, i.e. 1 second?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on 1 second

@dmitri-d
Copy link
Member Author

dmitri-d commented Feb 5, 2018

  • changed the default interval to 1 second.

@iNecas
Copy link
Member

iNecas commented Feb 6, 2018

Thanks @witlessbird

@iNecas iNecas merged commit 5240ea7 into theforeman:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iNecas iNecas iNecas left review comments

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
Ready to merge
Projects
None yet
Milestone
No milestone
4 participants
@dmitri-d @iNecas @adamruzicka @theforeman-bot