Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added asserts to template details test #336

Merged
merged 1 commit into from Mar 29, 2018
Merged

added asserts to template details test #336

merged 1 commit into from Mar 29, 2018

Conversation

pondrejk
Copy link
Contributor

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 7958ceb must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@pondrejk pondrejk changed the title added asserts to template details test Fixes #22450 added asserts to template details test Mar 27, 2018
@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 55f3aea must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@pondrejk pondrejk changed the title Fixes #22450 added asserts to template details test added asserts to template details test Mar 27, 2018
@iNecas
Copy link
Member

iNecas commented Mar 27, 2018

ok to test

@iNecas
Copy link
Member

iNecas commented Mar 27, 2018

Running tests at http://ci.theforeman.org/job/test_plugin_pull_request/4830/

@mmoll
Copy link
Contributor

mmoll commented Mar 28, 2018

sqlite3 test failures were fixed in master, so these are unrelated here

@adamruzicka
Copy link
Contributor

[test]

@mmoll
Copy link
Contributor

mmoll commented Mar 29, 2018

without getting rebased, tests will still fail like thay did before

@mmoll
Copy link
Contributor

mmoll commented Mar 29, 2018

aw, please disregard my last comment, in plugins, as opposed to core, changes from PR are merged into the current development branch.

@adamruzicka
Copy link
Contributor

You had me worried there for a moment :)

adamruzicka
adamruzicka approved these changes Mar 29, 2018
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adamruzicka adamruzicka merged commit 8f5365c into theforeman:master Mar 29, 2018
@adamruzicka
Copy link
Contributor

Thanks @pondrejk, @mmoll !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmoll mmoll mmoll approved these changes

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
5 participants
@pondrejk @theforeman-bot @iNecas @mmoll @adamruzicka