Refs #21731 - revert using loop instead of process
#351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In e65c15a, the `process` call was replaced with `loop` for no obvious reason. This change leads potentially for the commands to get stuck. I've reproduced this by trying `sudo` effective method without `sudo` being present on the system.
pondrejk
approved these changes
May 11, 2018
|
Thanks @pondrejk for review and testing. |
|
Merging as the issues is potentially causing quite a lot of troubles, so I would like to have that in before new release. |
MariaAga
pushed a commit
to MariaAga/foreman_remote_execution
that referenced
this pull request
Sep 3, 2021
Allows seeing which options is the user running the cleanup script with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In e65c15a, the
processcall was replaced withloopfor no obviousreason. This change leads potentially for the commands to get stuck.
I've reproduced this by trying
sudoeffective method withoutsudobeing present on the system.