Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #21704 - Prevent user from rerunning a job with missing template #358

Merged
merged 6 commits into from Aug 6, 2018
Merged

Fixes #21704 - Prevent user from rerunning a job with missing template #358

merged 6 commits into from Aug 6, 2018

Conversation

adamruzicka
Copy link
Contributor

No description provided.

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for 3391792 exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@adamruzicka adamruzicka changed the title Fixes #21704 - Prevent user from rerunning a job with missing template [WIP] Fixes #21704 - Prevent user from rerunning a job with missing template Jun 13, 2018
adamruzicka
adamruzicka commented Jun 13, 2018
View reviewed changes
Copy link
Contributor Author

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really ready, just want to see if the tests will exhibit the same issue as #357

@adamruzicka
Copy link
Contributor Author

image

In case users try to rerun a job for which they can't see the template, the new job invocation form shows an error box, no job category is selected and the submit button is disabled. After they select a proper category-template combination, the form redraws, error box disappears and submit button gets enabled.

@adamruzicka adamruzicka changed the title [WIP] Fixes #21704 - Prevent user from rerunning a job with missing template Fixes #21704 - Prevent user from rerunning a job with missing template Aug 2, 2018
@iNecas
Copy link
Member

iNecas commented Aug 3, 2018

Would it be possible to cover this with some tests. At least one for rerun_possible? method.

Also; how would the API behave in this case, or it's not affected at all?

@iNecas
Copy link
Member

iNecas commented Aug 3, 2018

Test failures seem related

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for ca7982f exceeds 65 characters
  • length of the first commit message line for d76a30f exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for ca7982f exceeds 65 characters
  • length of the first commit message line for d76a30f exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

iNecas
iNecas approved these changes Aug 6, 2018
View reviewed changes
Copy link
Member

@iNecas iNecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well.

@iNecas iNecas merged commit 7a94a2d into theforeman:master Aug 6, 2018
@iNecas
Copy link
Member

iNecas commented Aug 6, 2018

Thanks @adamruzicka

MariaAga pushed a commit to MariaAga/foreman_remote_execution that referenced this pull request Sep 3, 2021
@iNecas @adamruzicka
Fixes #24872 - fix import_facts deprecation (theforeman#358)
4aa9606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iNecas iNecas iNecas approved these changes

Assignees
No one assigned
Labels
Needs testing Waiting on contributor
Projects
None yet
Milestone
No milestone
3 participants
@adamruzicka @theforeman-bot @iNecas