Fixes #23394 - Unable to set effective user for job templates #361
Conversation
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
theforeman-bot
added
Waiting on contributor
Needs testing
Not yet reviewed
and removed
Waiting on contributor
labels
| param :current_user, :bool, :desc => N_('Whether the current user login should be used as the effective user') | ||
| end | ||
| param :effective_user_attributes, Hash, :desc => N_('Effective user options') do | ||
| param :value, String, :desc => N_('What user should be used to run the script (using sudo-like mechanisms)'), :allowed_nil => true |
There was a problem hiding this comment.
Having this called value makes sense in the API context, but in hammer having an option called value, which is not really a value of the object you're manipulating with, feels weird
hammer job-template create \
--file my_template.erb \
--name my_template \
--job-category Misc \
--provider-type SSH \
--value nobodyMaybe renaming this either in the apidoc or in hammer would lead to a better user experience
There was a problem hiding this comment.
I do agree with you, but I don't think it should be on this PR, this one just fixes an issue, another PR can be on better naming things
There was a problem hiding this comment.
Ah, so it was called value even before, but it didn't work. Guess I'm ok with that
There was a problem hiding this comment.
the ssh hash was inaccessible because it does not exists anywhere else, so I fixed that.
There was a problem with the API structure, it didn't work since day one. The `ssh` sub entry was not recognized by `strong params`, making the `ssh` object (hash) and children not to be accessible. This PR fixes the issue, but "breaks" the bad API documentation that existed before.
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
done :) |
|
Thanks @ik5 ! |
There was a problem with the API structure, it didn't work since day one.
The
sshsub entry was not recognized bystrong params, making thesshobject (hash) and children not to be accessible.
This PR fixes the issue, but "breaks" the bad API documentation that existed
before.