Fixes #22209 - Render empty lines properly in output #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the output uses CRLF to mark a newline, writing CRs into the terminal window led to line numbers not matching the lines. Also we were splitting the output on newlines and trailing empty fields were omitted.
|
This still doesn't work fully for ansible and it is related to the output colorization code. WIP |
There was an issue when line had color information but was otherwise empty. Also multiple consecutive spaces were removed by the browser due to missing css property.
houndci-bot
reviewed
Sep 19, 2018
| @@ -1,4 +1,5 @@ | |||
| module JobInvocationOutputHelper | |||
| COLOR_PATTERN = /\e\[.*?m/.freeze | |||
There was a problem hiding this comment.
Style/RedundantFreeze: Do not freeze immutable objects, as freezing them has no effect.
iNecas
reviewed
Sep 19, 2018
| color = seq[/(\d+)m/,1] | ||
| "{{{format color:#{color}}}}" | ||
| end | ||
|
|
||
| current_color = 'default' | ||
| out = %{<span style="color: #{@current_color}">} | ||
| out = %{<span style="color: #{current_color}">} |
There was a problem hiding this comment.
Isn't the issue now, that the colorization doesn't survive the the new line?
rhlogo.zip
|
Fixed |
iNecas
approved these changes
Sep 19, 2018
|
Test failures don't seem to be related |
|
Test failures unrelated. Thanks @adamruzicka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the output uses CRLF to mark a newline, writing CRs into
the terminal window led to line numbers not matching the lines. Also we
were splitting the output on newlines and trailing empty fields were
omitted.
To reproduce run the following