Fixes #26689 - remove lookup_keys from views #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do we need to initialize this another way? this probably changed during moving template inputs to core right? |
the original issue was that lookup_keys were always complied into the application.js, we simply removed it from being complied again in core. including here additionally was never needed. |
|
Thanks @xprazak2 |
MariaAga
pushed a commit
to MariaAga/foreman_remote_execution
that referenced
this pull request
Sep 3, 2021
…eforeman#411) * Fixes #26560 - paused tasks notification and troubleshooting info This path adds notifications and troubleshooting info for pauses tasks Troubleshooting info -------------------- A new `TroubleshootingHelpGenerator` service class has been added to provide troubleshooting info for paused tasks. By default, it provides generic information explaining the situation and link to troubleshooting documentation (in case Setting[:foreman_tasks_troubleshooting_url] is set. The troubleshooting_url can contain macros for foreman version and normalized task label (the label without non-alhpanumeric characters). For example, for the following url setting: https://tfm.org/%{version}/tasks_troubleshooting.html#%{label} and task 'Plugin::MyTask', the generated url would be: https://tfm.org/1.22/tasks_troubleshooting.html#PluginMyTask The setting is currently not set (which means the troubleshooting link to currently generated. We will add the setting once the page is ready in docs. It's also possible to extend the troubleshooting info and links on per-action basis, by defining specific action method (see `test/support/dummy_dynflow_action.rb` for example on how to define it. Admin notifications ------------------- Every time there is paused task, an admin gets a notification about current amount of paused tasks with links to: 1. list of paused tasks 2. troubleshooting links from `TroubleshootingHelpGenerator` - the label for the troubleshooting url is filled with `''` in this case. In case new paused task is added, the previous notification is removed and an update notification is generated, so that the user's notification is not overloaded with data. Owner notification ------------------ In case the task is triggered by some user (the host-related tasks are out of scope), the owner should the notification about the single task being paused, with links to 1. details of the task 2. troubleshooting info for the task How to test ----------- 1. set the `foreman_tasks_troubleshooting_url` config to some url (as example might be https://access.redhat.com/solutions/satellite6-tasks) 2. make some tasks to get paused 3. look at the notification drawer 4. loot the the details of the task * Refs #26560 - address review comments * Refs #26560 - don't remove :: from labels in anchors * Refs #26560 - increase timeout time in tests To avoid intermittent test failures. * Refs #26560 - better isolation of the in-thread executor I've been hitting issues with the in-thread executor, as it was using the same database as other test worlds, and there were some issues with messy data in test database + possible file-system locks (at least with sqlite).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.