Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #27489 - remove global in eslint config #424

Merged
merged 1 commit into from Aug 1, 2019
Merged

Fixes #27489 - remove global in eslint config #424

merged 1 commit into from Aug 1, 2019

Conversation

amirfefer
Copy link
Member

i18n capabilities and jquery should be imported in react code, ie:

import { translate as __ } from 'foremanReact/common/i18n`
import $ from 'jquery'

adamruzicka
adamruzicka approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested together with #423 , works well.

@adamruzicka adamruzicka merged commit f105f3a into theforeman:master Aug 1, 2019
@adamruzicka
Copy link
Contributor

Thank you @amirfefer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
3 participants
@amirfefer @adamruzicka @theforeman-bot