Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #31711 - Extend API params for generating registration command #561

Merged
merged 1 commit into from Apr 26, 2021
Merged

Fixes #31711 - Extend API params for generating registration command #561

merged 1 commit into from Apr 26, 2021

Conversation

stejskalleos
Copy link
Contributor

@stejskalleos stejskalleos commented Jan 25, 2021 •
edited

adamruzicka
adamruzicka approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, but let's hold it for a bit until we get at least one 2.4 release out of the door

@adamruzicka adamruzicka changed the title Extend API params for generating registration command Fixes #31711 - Extend API params for generating registration command Mar 9, 2021
@adamruzicka adamruzicka added this to the v4.4.0 milestone Apr 9, 2021
@adamruzicka adamruzicka merged commit 9c3e508 into theforeman:master Apr 26, 2021
@adamruzicka
Copy link
Contributor

Thank you @stejskalleos !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
Ready to merge
Projects
None yet
Milestone
v4.4.0
3 participants
@stejskalleos @adamruzicka @theforeman-bot