Fixes #32539 - Stop loading rex core into regular rex #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
This is really all what it takes to get rid of this? 🤦 |
|
Well, not really. It just prepares the ground for this one #587 |
|
I meant to get rid of the dependency of rex to rex_core :) I always thought there is something we really share between proxy and foreman, that I still just don't understand |
|
Ah, there used to be. But now this seems to be the only thing left. |
ezr-ondrej
reviewed
May 10, 2021
|
I would like to keep that around until we remove rex_core for good so we don't mess up the dependency chain. I'm not sure if anything pulls in rex core explicitly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.