Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #33662 - Job wizard allow unselecting template inputs #664

Merged
merged 2 commits into from Nov 16, 2021
Merged

Fixes #33662 - Job wizard allow unselecting template inputs #664

merged 2 commits into from Nov 16, 2021

Conversation

MariaAga
Copy link
Member

@MariaAga MariaAga commented Nov 1, 2021

if the template input is not required there should be an empty option
depends on #663

@adamruzicka
Copy link
Contributor

#663 just got in

adamruzicka
adamruzicka approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, ACK

@adamruzicka adamruzicka merged commit 8a193ee into theforeman:master Nov 16, 2021
@adamruzicka
Copy link
Contributor

Thank you @MariaAga !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
3 participants
@MariaAga @adamruzicka @theforeman-bot