Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #32676 - Fix long job name on dashboard #691

Merged
merged 2 commits into from Feb 22, 2022

Conversation

pkoprda
Copy link
Contributor

@pkoprda pkoprda commented Feb 3, 2022

When job name was longer, the tooltip was displayed twice.

tooltip-dual

@adamruzicka
Copy link
Contributor

Seems to work fine. @MariaAga could you take a look if this is the way to go?

@ezr-ondrej
Copy link
Member

I guess we could have a class and extract the styles into a stylesheet, but no hard feelings against inline styles if kept small :)

@MariaAga
Copy link
Member

MariaAga commented Feb 3, 2022

^agree
It's a good solutions, but there are still 2 tooltips, I think one comes from here:

trunc_with_tooltip(description, 80)

@pkoprda
Copy link
Contributor Author

pkoprda commented Feb 7, 2022

Thanks @MariaAga for advice, I think it's better to keep ellipsis class

@adamruzicka
Copy link
Contributor

The helper did more than just truncating the text and adding a tooltip. It also capitalized the text and provided a default value, both of which is not missing. Although to be fair the default value doesn't seem to detect empty strings as blank values

image

@adamruzicka
Copy link
Contributor

adamruzicka commented Feb 15, 2022

Re-kicked the tests and they turned 🍏

@adamruzicka adamruzicka merged commit a5ac833 into theforeman:master Feb 22, 2022
@adamruzicka
Copy link
Contributor

Thank you @pkoprda !

@pkoprda pkoprda deleted the long-status-job branch February 22, 2022 15:27
adamruzicka pushed a commit that referenced this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants