fixes #12218 - check if query and bookmark are blank not nil #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbenjam
force-pushed
the
12218
branch
2 times, most recently
from
ce98aba
to
6721a3d
Compare
|
One thing I've inoticed while testing: although the validation prevents from continuing, the information about number of resolved hosts is still not valid : it says 73 hosts, while it should be either 0 or info about search query missing |
|
@stbenjam LOL, ACK then, tested and works great! |
stbenjam
added a commit
that referenced
this pull request
Nov 10, 2015
fixes #12218 - check if query and bookmark are blank not nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.