Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24962 - Make graph in job details clickable #727

Merged
merged 3 commits into from Dec 20, 2022

Conversation

adamruzicka
Copy link
Contributor

@adamruzicka adamruzicka commented May 30, 2022

Known issues:

  • the row with chips is most likely wrongly aligned
  • the donut chart itself does not indicate the selection, haven't found an easy way how to do that
  • the search doesn't really work for hosts which don't have their task yet, but that is nothing new
vokoscreenNG-2022-05-30_15-18-09.mp4

@ofedoren
Copy link
Member

Thanks, @adamruzicka! Just a small pre-review, so we don't have a lot of "JS rubocop" warnings: you can run npm run lint locally to see the places that need to be treated. It also provides automatic fixes, but I forgot how to run that :/

@adamruzicka adamruzicka force-pushed the interactive-details branch 6 times, most recently from bb165b9 to ac28687 Compare December 9, 2022 13:23
Also fix status -> search mapping
Copy link
Contributor

@stejskalleos stejskalleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏 LGTM, works as expected

@ares
Copy link
Member

ares commented Dec 20, 2022

Thanks @adamruzicka and @stejskalleos, merging!

@ares ares merged commit c58eb03 into theforeman:master Dec 20, 2022
@adamruzicka adamruzicka deleted the interactive-details branch January 2, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants