Fixes #12288 - disable transactions for plan phase in run host job action #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose tests failed because it needs newer dynflow? |
|
Yes |
…tion Otherwise we lose the link from the task to the job invocation. Since in this case, the execution plan is not driving a transaction between local database and external systems, we can turn this logic off for this action. Due to dependencies on Dynflow, we need to add the dependency to dynflow 0.8.8 although foreman-tasks works also with older versions.
iNecas
force-pushed
the
dont-use-transactions-for-ssh
branch
from
ae63f74
to
5f73947
Compare
|
The tests are green now |
| @@ -10,6 +11,9 @@ def resource_locks | |||
|
|
|||
| def plan(job_invocation, host, template_invocation, proxy, connection_options = {}) | |||
| action_subject(host, :job_name => job_invocation.job_name) | |||
| link!(job_invocation) | |||
| link!(template_invocation) | |||
|
|
|||
There was a problem hiding this comment.
The reason for moving those three lines is to create the links before any error can be raised?
There was a problem hiding this comment.
We need to do that as soon as possible, before any other error occurs, so that one can get to the errors form the linked resource
|
Works as expected, ACK |
iNecas
added a commit
that referenced
this pull request
Dec 8, 2015
Fixes #12288 - disable transactions for plan phase in run host job action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we lose the link from the task to the job invocation. Since
in this case, the execution plan is not driving a transaction between
local database and external systems, we can turn this logic off for
this action.
With this patch (that depends on Dynflow/dynflow#174),
when there is an issue with running the job on proxy (as in case when the proxy
is just down), we show the tasks on per-host part as failed, with posibility to
show details, as with any other error.