Fixes #36089 - Job wizard default to no hosts selected #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
requested changes
Feb 13, 2023
|
Need to change the message + logic to allow 0 hosts selected but not allow no host selection |
MariaAga
force-pushed
the
default_no_hosts
branch
from
9de246f
to
53ed208
Compare
|
Redone the pr to treat the hosts field as a required field |
MariaAga
force-pushed
the
default_no_hosts
branch
2 times, most recently
from
c5638e9
to
5d6437b
Compare
|
Once I fill in required inputs, it allows me to go to the review step and kick the job off even though no hosts are selected. Is that intentional? |
MariaAga
force-pushed
the
default_no_hosts
branch
from
5d6437b
to
4530f5a
Compare
|
missed condition check in the last step, added it. review should be disabled if there are no hosts/search query |
|
Thank you @MariaAga ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using the magic of1=0like ruby does atif displayed_search_query.blank? Host.where('1 = 0')Checking if any of the host selections are selected after a user clicks the host input, if not it will show an error
