Fixes #36096 - Add provider inputs to job wizard #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamruzicka are these normal ruby test failures? |
MariaAga
force-pushed
the
wizard-provider-inputs
branch
from
c66e8f7
to
95b35b2
Compare
|
rebased and the test failures are gone |
adamruzicka
approved these changes
Feb 21, 2023
|
Thank you @MariaAga ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding them in the api response as part of the advanced inputs so that the ui will treat them as template inputs, and split them on submit from the advanced inputs.
Tested that they were actually added with
TemplateInvocation.last.provider_input_values.first.value