Fixes #12926 - add rerun to host row in job detail #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def template_invocation_actions(task, host, job_invocation) | ||
| [ | ||
| display_link_if_authorized(_('View host'), hash_for_host_path(host).merge(:auth_object => host, :permission => :view_hosts)), | ||
| display_link_if_authorized(_('Rerun on %s') % host.name, hash_for_rerun_job_invocation_path(:id => job_invocation, :host_ids => [ host.id ])), |
There was a problem hiding this comment.
Is there a reason to show the hostname? Don't think we do that anywhere else in Foreman, do we? I think it looks OK, but it'd be weird if there were multiple action items because you already know the host based on the row the button's in.
There was a problem hiding this comment.
I wanted to be clear about on which host it's going to be run, without following the whole line to the left. But I can easily change it to 'Rerun' only if you prefer. Or maybe 'Rerun on this host'
There was a problem hiding this comment.
No strong preference either way, the way it is now is OK
stbenjam
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
rebased, still ongoing discussion in outdated diff |
|
APJ |
ares
added a commit
that referenced
this pull request
Jan 4, 2016
Fixes #12926 - add rerun to host row in job detail
MariaAga
pushed a commit
to MariaAga/foreman_remote_execution
that referenced
this pull request
Sep 3, 2021
Add package installation to README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #92 to avoid conflicts, please review just the second commit or ideally review the second PR first...