WIP - new host details tab extention #358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ron-Lavi
force-pushed
the
feat/register_ex_host_tab
branch
from
acca34f
to
2515321
Compare
|
still a WIP, but made css to work 🎆 @ShimShtein @sharvit @amirfefer
|
amirfefer
suggested changes
Nov 3, 2020
Comment on lines
11
to
16
| def plugin_css_path | ||
| link_element = helpers.css_tags_for([:foreman_rh_cloud]).first | ||
| render json: { | ||
| linkElement: link_element, | ||
| }, status: :ok | ||
| end |
There was a problem hiding this comment.
css importing works out of the box with theforeman/foreman#8123
There was a problem hiding this comment.
awesome! great job @amirfefer
webpack/global_index.js
Outdated
Comment on lines
26
to
29
| case 'subscriptions': | ||
| window.tfm.store.observeStore( | ||
| 'katello.subscriptions.itemCount', | ||
| subscriptionCountListener |
There was a problem hiding this comment.
it was brought from the older global_js file
webpack/global_index.js
Outdated
| subscriptionCountListener | ||
| ); | ||
| break; | ||
| case 'experimental': |
There was a problem hiding this comment.
is this switch case triggering once or on every page transition?
Scenario:
- Go to a react based page (i.e Audits) - This switch case catch nothing
- Navigate to a hosts details page - This switch case isn't re-triggered
- Insights tab isn't registered
If this switch case triggers on every page transition we need to verify that we don't register fills twice.
There was a problem hiding this comment.
need a bit more investigation, though IMO when it comes to React pages it will get registered just once.
Ron-Lavi
force-pushed
the
feat/register_ex_host_tab
branch
from
2515321
to
f5a1e9c
Compare
|
Needs a rebase, also general ping :) |
|
opened a new PR in #653 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a WIP