limit remediation to specific host even if all selected on new host page #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are fixed in master, can you please rebase? |
Ron-Lavi
force-pushed
the
fix/host_page_remediation_modal
branch
from
50d7a20
to
66f824a
Compare
|
updated |
|
@Ron-Lavi rebase please? |
at the moment, when user select all recommendations from all pages all hosts resolution was shown. when the user views the insights table from the host page, we should limit to that specific host.
Ron-Lavi
force-pushed
the
fix/host_page_remediation_modal
branch
from
66f824a
to
4b18c91
Compare
|
yay! it's green now |
|
Merged, thanks @Ron-Lavi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at the moment, when the user selects all recommendations from all pages
all host's resolutions was shown.
when the user views the insights table from the host page,
we should limit it to that specific host.