Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job_finished_message should indicate overall playbook status #745

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Jun 10, 2022

consoleDot expects the playbook_run_completed status to indicate if the playbook succeeded for all hosts or indicate failure if at least one host failed.

@tahmidefaz @aleccohan -- could you verify this looks as you are expecting?

Copy link

@tahmidefaz tahmidefaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Seems like you are flipping the success/failure status of the whole playbook run correctly. 👍

@Ichimonji10
Copy link

Ichimonji10 commented Jun 10, 2022

Bug tracked in SAT-10934.

@ShimShtein ShimShtein merged commit 1f64621 into theforeman:master Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants