Fix hostgroup tests (#91)

theforeman · Apr 26, 2019 · e8f7009 · e8f7009
1 parent f638837
commit e8f7009
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/test/unit/hostgroup_extensions_test.rb b/test/unit/hostgroup_extensions_test.rb
@@ -21,20 +21,26 @@ class HostgroupExtensionsTest < ActiveSupport::TestCase
 
     test 'child host group inherits salt proxy from child parent' do
       parent = FactoryBot.create :hostgroup
-      child_one = FactoryBot.create :hostgroup, :parent => parent
-      child_one.salt_proxy = @proxy
-      child_one.reload
+      child_one = FactoryBot.create :hostgroup, :parent => parent, :salt_proxy => @proxy
       child_two = FactoryBot.create :hostgroup, :parent => child_one
+      assert_not_nil parent
+      assert_not_nil child_one
+      assert_not_nil child_two
+      assert_not_nil child_one.salt_proxy
+      assert_not_nil child_two.salt_proxy
       assert_equal child_two.salt_proxy, child_one.salt_proxy
     end
 
     test 'child host group inherits salt environment from child parent' do
       environment = FactoryBot.create :salt_environment
       parent = FactoryBot.create :hostgroup
-      child_one = FactoryBot.create :hostgroup, :parent => parent
-      child_one.salt_environment = environment
-      child_one.reload
+      child_one = FactoryBot.create :hostgroup, :parent => parent, :salt_environment => environment
       child_two = FactoryBot.create :hostgroup, :parent => child_one
+      assert_not_nil parent
+      assert_not_nil child_one
+      assert_not_nil child_two
+      assert_not_nil child_one.salt_environment
+      assert_not_nil child_two.salt_environment
       assert_equal child_two.salt_environment, child_one.salt_environment
     end