fixes #12433 - update salt proxy from grains

[stbenjam]

No description provided.

[ehelms]

LGTM from a code perspective

[stbenjam]

Oh my someone reviewed a foreman_salt PR? 🎉

Thanks :-)

[ehelms]

I'd be happy to test this from a functionality perspective if you were willing to give me steps for a basic setup or point me to me documentation to try out.

[stbenjam]

I think it's OK without functional testing, once I fix tests against master, the test here does make sure it works.

Of course you're welcome to try it out, but it means installing a salt master and getting it up and running. You'd just be confirming a host created by facts (salt grains) or a report creates a host, and updates the salt master.

[mmoll]

what's the status here? :)

[joberget]

Any update on this issue?

[mmoll]

this needs at least a rebase ;)

[joberget]

I am getting the following error on foreman 1.12.2:

/usr/bin/foreman-node server

/usr/bin/foreman-node:188:in <main>': Object#timeout is deprecated, use Timeout.timeout instead. Could not get grains: undefined methodeach_pair' for nil:NilClass