Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #25500 - Ruby 1.8.7 compatibility for RHEL6 #25

Merged
merged 1 commit into from Jan 29, 2019
Merged

Fixes #25500 - Ruby 1.8.7 compatibility for RHEL6 #25

merged 1 commit into from Jan 29, 2019

Conversation

xprazak2
Copy link
Contributor

Unfortunately, ruby 1.8.7 has no support for passing env variables into commands, so we need additional gem.

@xprazak2 xprazak2 mentioned this pull request Nov 26, 2018
Closed
4 tasks
ares
ares requested changes Jan 14, 2019
View reviewed changes
Copy link
Member

@ares ares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed on IRC, it would be good to avoid that dependency on newer rubies, perhaps we don't have to support HTTP proxy on old ruby either as it's a new feature

@xprazak2 xprazak2 force-pushed the posix-cp branch 2 times, most recently from 725efd8 to 77e11e3 Compare January 15, 2019 11:49
ares
ares approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@ares ares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xprazak2, merging!

@ares ares merged commit ccdd08c into theforeman:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ares ares ares approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xprazak2 @ares