Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #28419 - Improve tooltips for sync settings #129

Merged
merged 1 commit into from Dec 11, 2019

Conversation

xprazak2
Copy link
Contributor

@xprazak2 xprazak2 commented Dec 4, 2019

@jyejare, do the changes seem ok to you? I decided to keep the question marks for now, do you have any suggestions on how to rephrase the text so that is no longer a question?

@ares
Copy link
Member

ares commented Dec 10, 2019

Needs a rebase now, I also asked @jyejare to confirm texts. Hopefully we can get this in by thursday and cut a new release.

@xprazak2 xprazak2 force-pushed the tooltips-imps branch 2 times, most recently from 6c33cb5 to 7905c88 Compare December 11, 2019 08:26
Copy link
Member

@ares ares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jyejare is on PTO, let's go ahead and merge this for now, strings can be easily improved later as well. Thanks @xprazak2, merging!

@ares ares merged commit c01f22f into theforeman:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants