Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #19294 - support templates from any context #46

Merged
merged 1 commit into from Apr 24, 2017
Merged

Fixes #19294 - support templates from any context #46

merged 1 commit into from Apr 24, 2017

Conversation

ares
Copy link
Member

@ares ares commented Apr 18, 2017

No description provided.

@ares ares added the 5.0 label Apr 18, 2017
adamruzicka
adamruzicka approved these changes Apr 19, 2017
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected

@ares
Copy link
Member Author

ares commented Apr 20, 2017

[test]

@GregSutcliffe
Copy link
Member

Seems to work, ACK pending tests.

@ares
Copy link
Member Author

ares commented Apr 20, 2017

Test failures unrelated, not introduced by plugin, fixed by #48

@GregSutcliffe
Copy link
Member

[test]

@ares
Copy link
Member Author

ares commented Apr 21, 2017

@GregSutcliffe tests are green, 4.0.2 released so I think this can get in

@GregSutcliffe GregSutcliffe merged commit e078c13 into theforeman:master Apr 24, 2017
@GregSutcliffe
Copy link
Member

Done, thanks @ares and @adamruzicka!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregSutcliffe GregSutcliffe GregSutcliffe approved these changes

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
5.0 Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ares @GregSutcliffe @adamruzicka @theforeman-bot