Fixes #23958 - Improve error message for file system access denial #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ares
requested changes
Jun 21, 2018
| @@ -33,7 +33,9 @@ def get_absolute_repo_path | |||
| end | |||
|
|
|||
| def verify_path!(path) | |||
| raise "Using file-based synchronization, but couldn't find #{path}" unless Dir.exist?(path) | |||
| msg = _("Using file-based synchronization, but couldn't access %s to export templates. ") % path | |||
| msg += _("Please check the access permissions/SELinux and make sure it is writable for 'foreman' system user.") | |||
There was a problem hiding this comment.
Dev setups might run under different user. Can we either figure out current effective user or rephrase to something like the web application user account, typically 'foreman'
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
ares
approved these changes
Jul 3, 2018
|
Works fine, thanks @xprazak2, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The export to file system works correctly as far as I can tell. The exception is raised when
pathdoes not exist or the user does not have proper permissions set up. For example, exports to/root/repowill (correctly) fail on this because foreman does not even have read permissions for/root, therefore it cannot find/root/repo. Improving the error message is the only thing we can do here.