Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n - extracting new, pulling from tx #163

Merged
merged 1 commit into from May 18, 2023
Merged

Conversation

lfu
Copy link
Contributor

@lfu lfu commented May 16, 2023

  • Extract missing strings for the translations
  • Update config for the transifex-cli
  • Update *.po files
  • Add logic to gemspec to warn if mo-files are not present

@lfu lfu force-pushed the i18n_6_14 branch 2 times, most recently from 361c894 to c4b5913 Compare May 16, 2023 21:37
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks @lfu for removing the MO files and updating areas that were not being translated correctly. Feel free to merge.

@chris1984 chris1984 self-assigned this May 18, 2023
@lfu lfu merged commit 0bc1890 into theforeman:master May 18, 2023
1 check passed
ekohl added a commit to ekohl/foreman_virt_who_configure that referenced this pull request Sep 15, 2023
These files don't have any translations and shouldn't be shipped.

Fixes: 0bc1890 ("i18n - extracting new, pulling from tx (theforeman#163)")
chris1984 pushed a commit that referenced this pull request Sep 18, 2023
These files don't have any translations and shouldn't be shipped.

Fixes: 0bc1890 ("i18n - extracting new, pulling from tx (#163)")
@lfu lfu deleted the i18n_6_14 branch November 3, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants