Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36875 - Add github action using docker #175

Merged
merged 1 commit into from Oct 31, 2023
Merged

Fixes #36875 - Add github action using docker #175

merged 1 commit into from Oct 31, 2023

Conversation

lfu
Copy link
Contributor

@lfu lfu commented Oct 30, 2023

No description provided.

chris1984
chris1984 requested changes Oct 30, 2023
View reviewed changes
.github/images/npm_install_plugins.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of this file since we are not doing an JS testing unless it's causing issues locally

.github/images/.pnpmfile.cjs Outdated Show resolved Hide resolved
.github/images/Dockerfile Show resolved Hide resolved
.github/images/Dockerfile Outdated Show resolved Hide resolved
.github/images/run_tests.sh Outdated Show resolved Hide resolved
.github/images/run_tests.sh Outdated Show resolved Hide resolved
@lfu lfu force-pushed the test_setup branch 3 times, most recently from 631a12e to 7a2c694 Compare October 30, 2023 20:30
@lfu lfu changed the title Add github action using docker Fixes #36875 - Add github action using docker Oct 30, 2023
chris1984
chris1984 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left 1 comment, if it fails by removing nodejs then let's keep it otherwise update and we can merge this. ACKING this so you can merge it regardless

.github/images/Dockerfile Outdated Show resolved Hide resolved
@lfu lfu merged commit 8bd4da4 into theforeman:master Oct 31, 2023
1 check passed
lfu added a commit to lfu/foreman_virt_who_configure that referenced this pull request Oct 31, 2023
@lfu
Add github action using docker (theforeman#175)
54837e8
@lfu lfu deleted the test_setup branch November 3, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lfu @chris1984