Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #36875 - finalize github action workflow #181

Merged
merged 1 commit into from Nov 7, 2023
Merged

Refs #36875 - finalize github action workflow #181

merged 1 commit into from Nov 7, 2023

Conversation

lfu
Copy link
Contributor

@lfu lfu commented Nov 7, 2023

No description provided.

chris1984
chris1984 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean file and nice work @lfu

I can proudly say our test infra is much cleaner than rh_cloud because of your hard work :) Merge away.

I am guessing the tests will go green once we get the rubocop one?

@chris1984 chris1984 self-assigned this Nov 7, 2023
@lfu lfu merged commit f912445 into theforeman:master Nov 7, 2023
1 of 2 checks passed
@lfu lfu deleted the ci_gh_workflow branch November 30, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 approved these changes

Assignees

@chris1984 chris1984

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lfu @chris1984