Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n - pulling from tx #182

Merged
merged 3 commits into from Nov 30, 2023
Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Nov 28, 2023

No description provided.

This file is automatically generated and doesn't need to be tracked.
@ekohl ekohl marked this pull request as draft November 28, 2023 14:09
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lfu Since you are doing the release of virt-who-configure, are you able to review this one? Once it's out of Draft state.

@ekohl ekohl marked this pull request as ready for review November 28, 2023 20:59
@lfu
Copy link
Contributor

lfu commented Nov 29, 2023

I'm not sure if .mo files should be tracked in the repo. Looks like Foreman and Katello are not tracking .mo files.
@ekohl Any input?

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ekohl

@chris1984 chris1984 merged commit b28652b into theforeman:master Nov 30, 2023
2 checks passed
@ekohl ekohl deleted the update-translations branch November 30, 2023 16:42
@ekohl
Copy link
Member Author

ekohl commented Nov 30, 2023

I'm not sure if .mo files should be tracked in the repo. Looks like Foreman and Katello are not tracking .mo files.

That's a good question and you're right: ideally we shouldn't keep them in git because they're the compiled .po files.

For Foreman we compile it in packaging:
https://github.com/theforeman/foreman-packaging/blob/5ff32fc75dbedd1c01eea9b39c184b87f1f3c609/packages/foreman/foreman/foreman.spec#L553-L554

For Katello the release process is a bit special and they're built locally so they're included in the .gem file, but not in git.

I started an approach that essentially does the same as Foreman for Katello: theforeman/foreman-packaging#10035

Once that works, we should be able to apply the same approach to all plugins and remove the files from git, add them to .gitignore to avoid storing compiled files in git.

Until then we take the ugly approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants