Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37054 - Fix config reporting in the UI #184

Merged
merged 1 commit into from Jan 18, 2024
Merged

Conversation

chris1984
Copy link
Member

@chris1984 chris1984 commented Jan 15, 2024

What are the changes introduced in this pull request?

  • We changed how configs worked in this PR d9a1b90 so all configs use 1 service user per organization instead of creating a user for each config which breaks virt-who when you have lots of configs being reported in. See here why

Considerations taken when implementing this change?

  • Right now, there is a limitation of virt-who which does not send which config on the filesystem it used and just groups everything into a single report. This makes it hard for us to determine which configs in the UI need to be updated. After talking with Partha, we have decided to just mark them all green when a virt-who report comes in and file an RFE to virt-who to attach the config/s name used in the JSON report it sends. That can be tracked here:

https://issues.redhat.com/browse/RHEL-21652

Once this is addressed we will go back and update the reporting task, look at the JSON for the config name and properly update them instead of marking them all green.

What are the testing steps for this pull request?

  • Install virt-who configure plugin either by adding it to forklift in extra plugins, or cloning the repo, adding to bundler.d in the foreman directory and then doing a db:migrate db:seed
  • Check out PR
  • Create a config for VMware (Ping me for creds)
  • Create a 2nd config for a different VMware instance (ping me for creds)
  • Run the deploy scripts for each one, verify that each report updates in the UI
  • Run systemctl restart virt-who verify both configs report green (This will fire both off at the same time)

Without PR by doing this, virt-who will report in, but the configs say No reported data

Copy link

@parthaa parthaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well ACK

@chris1984 chris1984 merged commit ef5be02 into master Jan 18, 2024
3 checks passed
@chris1984 chris1984 deleted the fix-reporting branch January 18, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants