Fixes #37204 - Move proxy params to correct location in virt-who.conf #189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
no_proxy
under[system_environment]
http/s_proxy
under[system_environment]
What are the testing steps for this pull request?
no_proxy
is not in the/etc/virt-who.conf
configignore_proxy
UI field, save and deploy the config check and see if you seeno_proxy=*
in the/etc/virt-who.conf
confighttp_proxy
under[system_environment]
https_proxy
under[system_environment]
If you don't want to deploy the config, you can just look at the script and see what it would put in
/etc/virt-who.conf
that is what I did when testing the changes before I tried to deploy them.With my PR it should look like this for each scenario:
HTTPS Proxy:
HTTP Proxy:
Ignore Proxy:
No Proxy: