Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36895 - Fix capitalization on Virt-who Configurations sidebar link #193

Merged
merged 1 commit into from
May 16, 2024

Conversation

chris1984
Copy link
Member

What are the changes introduced in this pull request?

  • Infrastructure > Virt-who configurations has wrong capitalization
  • Fixed configurations to be Configurations

What are the testing steps for this pull request?

  • Check out PR
  • Look at Side bar and verify it's showing Virt-who Configurations

Copy link
Contributor

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the readme, otherwise it looks good

README.md Outdated
foreman-rake db:seed
* This plugin requires Katello to be installed in your Foreman instance. If it's there, simply install a package with the plugin (rpm only), run migrations and seed by running:

`dnf install rubygem-foreman_virt_who_configure`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lines here get squished together:
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ianballou let me know how this looks?

Copy link
Contributor

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@chris1984 chris1984 merged commit f6f4457 into master May 16, 2024
35 checks passed
@chris1984 chris1984 deleted the fix-caps branch May 16, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants