Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #18605 - setup test infrastructure #29

Merged
merged 1 commit into from Feb 27, 2017
Merged

Refs #18605 - setup test infrastructure #29

merged 1 commit into from Feb 27, 2017

Conversation

ares
Copy link
Member

@ares ares commented Feb 24, 2017

No description provided.

@ares ares mentioned this pull request Feb 27, 2017
Merged
tstrachota
tstrachota reviewed Feb 27, 2017
View reviewed changes
app/models/foreman_virt_who_configure/auth_source_hidden_with_authentication.rb
@@ -1,5 +1,11 @@
module ForemanVirtWhoConfigure
class AuthSourceHiddenWithAuthentication < ::AuthSourceHidden
def self.default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@ares
Copy link
Member Author

ares commented Feb 27, 2017

this blocks the jenkins job from succeeding, once it's merged I hope the job will run

@tstrachota
Copy link
Member

@ares FYI I couldn't execute the tests via zeus:

Failed loading test file:
cannot load such file -- test_plugin_helper

Running rake test:foreman_virt_who_configure directly works fine, so I'm merging it.

@tstrachota tstrachota merged commit a5d4f73 into theforeman:master Feb 27, 2017
@ares
Copy link
Member Author

ares commented Feb 27, 2017 •
edited

interesting, does zeus rake test:foreman_virt_who_configure variant work? I usually use that for openscap plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstrachota tstrachota tstrachota left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ares @tstrachota