Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #19014 - add configuration name #37

Merged
merged 1 commit into from Apr 13, 2017
Merged

Fixes #19014 - add configuration name #37

merged 1 commit into from Apr 13, 2017

Conversation

ares
Copy link
Member

@ares ares commented Apr 7, 2017

Based on top of #36, I'll rebase once it's merged.

@tstrachota
Copy link
Member

👍 when the reports monitoring changes are merged.

@tstrachota
Copy link
Member

@ares can you please rebase?

@ares
Copy link
Member Author

ares commented Apr 12, 2017

@tstrachota rebased, please take another look, tests seems to be passing locally

Run options: --seed 33883

# Running:

.............................

Finished in 5.494934s, 5.2776 runs/s, 16.0147 assertions/s.

@tstrachota tstrachota merged commit f098e76 into theforeman:master Apr 13, 2017
@tstrachota
Copy link
Member

Merged, thanks @ares

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ares @tstrachota