Fixes #18611 - don't ask for libvirt password #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstrachota
reviewed
May 2, 2017
| element.parent().parent().hide(); | ||
| } else { | ||
| element.parent().parent().show(); | ||
| } |
There was a problem hiding this comment.
BTW you can do simply
element.closest('.form-group').toggle(selected_type != 'libvirt');
tstrachota
reviewed
May 2, 2017
| $('#foreman_virt_who_configure_config_listing_mode').change(virt_who_update_listing_mode); | ||
| $('#foreman_virt_who_configure_config_hypervisor_type').change(virt_who_update_hypervisor_fields); |
There was a problem hiding this comment.
There's an onchange callback on the line 31 already. Could you please either extract it into a function and put both .change calls next to each other or put the functions into the anonymous function on the line 31? Just to improve readability.
|
Thanks @tstrachota, I incorporated both comments and rebased the PR. Please take another look. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.