Fixes #23878 - Config association with organization

[upadhyeammit]

This adds missing dependent destroy of ForemanVirtWhoConfigure::Config class so when deleting the Organization it should consider deleting Virt Who configuration associated with Organization.

[upadhyeammit]

@ares request you to review it once, I used discovery plugin as example when writing concern, I tested it and its working, I am able to delete org when having config defined but still you have look at this once.

Thank You!

[ares]

Thanks @upadhyeammit, this seems to work with the original issue. There's still one more foreign key, that's failing though, I'm getting this now.

PG::ForeignKeyViolation: ERROR: update or delete on table "taxonomies" violates foreign key constraint "taxable_taxonomies_taxonomy_id_fk" on table "taxable_taxonomies" DETAIL: Key (id)=(4) is still referenced from table "taxable_taxonomies". : DELETE FROM "taxonomies" WHERE "taxonomies"."type" IN ('Organization') AND "taxonomies"."id" = $1

I'll need to look with my debugging environment, it's not clear why it fails now, perhaps it's related to the other linked objects from configuration, such as user

[upadhyeammit]

@ares I will check this once, will let you know my findings.

[upadhyeammit]

Hello,

If I see the error then I do see there are good number records in taxable_taxonomies referring to the organization which I tried to delete,

ESC[32m2018-10-22T07:28:11ESC[0m [ESC[31mEESC[0m|ESC[36mbacESC[0m|4fa15] PG::ForeignKeyViolation: ERROR: update or delete on table "taxonomies" violates foreign key constraint "taxable_taxonomies_taxonomy_id_fk" on table "taxable_taxonomies"
| DETAIL: Key (id)=(3) is still referenced from table "taxable_taxonomies".
| : DELETE FROM "taxonomies" WHERE "taxonomies"."id" = $1 (ActiveRecord::InvalidForeignKey)
| /home/vagrant/.rvm/gems/ruby-2.5.1/gems/activerecord-5.2.1/lib/active_record/connection_adapters/postgresql_adapter.rb:603:in async_exec' | /home/vagrant/.rvm/gems/ruby-2.5.1/gems/activerecord-5.2.1/lib/active_record/connection_adapters/postgresql_adapter.rb:603:in block (2 levels) in exec_no_cache'

katello=# select taxable_type, count(*) from taxable_taxonomies where taxonomy_id=3 group by taxable_type;
taxable_type | count
----------------------+-------
ProvisioningTemplate | 89
Ptable | 15
SmartProxy | 1
User | 1
Audited::Audit | 7
ReportTemplate | 4
(6 rows)

Foreign-key constraints:
"taxable_taxonomies_taxonomy_id_fk" FOREIGN KEY (taxonomy_id) REFERENCES taxonomies(id)

I feel like these associations should be getting handled somewhere already, I am checking it further, if you have any thoughts on this then request to comment.
_
Amit Upadhye.

[ares]

@upadhyeammit that looks as the cause, you're right. The problem is that when we try to delete org, new audit record is created and therefore new entry in taxable_taxonomies table. This happens after these relation were cleanup by has_many :taxable_taxonomies :dependent => :destroy

That's definitely unrelated, so this can be merged. Thanks!

[ares]

so in fact, it was actually audit created by the virt who configuration deletion, not yet sure how to fix it

[ares]

fix by the linked PR