Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36215 - Make arrays for TypeAhead mutable #56

Merged
merged 1 commit into from Apr 6, 2023
Merged

Fixes #36215 - Make arrays for TypeAhead mutable #56

merged 1 commit into from Apr 6, 2023

Conversation

ofedoren
Copy link
Member

No description provided.

@ofedoren ofedoren mentioned this pull request Mar 22, 2023
Merged
m-bucher
m-bucher approved these changes Mar 22, 2023
View reviewed changes
Copy link

@m-bucher m-bucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix works in my forklift and also on my foreman-3.1 scenario after cherry-picking onto webhooks-3.0.0

Thanks @ofedoren

adamruzicka
adamruzicka approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's get this in

@adamruzicka adamruzicka merged commit 4dbf9c8 into theforeman:master Apr 6, 2023
5 checks passed
@adamruzicka
Copy link
Contributor

Thank you @ofedoren & @m-bucher !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bucher m-bucher m-bucher approved these changes

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ofedoren @adamruzicka @m-bucher