Honor FOREMAN_REX_WORKDIR #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the (as of Go 1.17) deprecated ioutil.TempFile with os.CreateTemp. When calling os.CreateTemp with an empty dir the default directory for temporary files is used. On UNIX that's $TMPDIR if non-empty or /tmp.
|
@adamruzicka do you have someone to review? Ping me if you'd need me to :) |
ehelms
reviewed
Sep 19, 2023
src/main.go
Outdated
| if err := s.Serve(l); err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| } | ||
|
|
||
| func determineWorkdir() string { | ||
| workdir, workdirP := os.LookupEnv("FOREMAN_REX_WORKDIR") |
There was a problem hiding this comment.
I'd consider FOREMAN_YGG_WORKER_WORKDIR or FOREMAN_YGG_WORKDIR as I think that would follow the convention that is being targeted for environment variable declaration of workers. e.g. https://github.com/theforeman/foreman-operations-collection/blob/develop/roles/cloud_connector/templates/foreman_rh_cloud.toml.j2#L3-L8
Although maybe going the route you have here with a change in the future to a naming scheme that is yggdrasil-worker-foreman-rex would better reflect what it is and then this would be in line with that already.
There was a problem hiding this comment.
Naming is hard, changed to the first option you proposed
adamruzicka
force-pushed
the
working-dir2
branch
from
2333b95
to
79a4ce0
Compare
ehelms
approved these changes
Sep 20, 2023
adamruzicka
force-pushed
the
working-dir2
branch
from
79a4ce0
to
8b05deb
Compare
This was referenced Sep 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #15
Includes #13
Companion to theforeman/foreman-packaging#9817