Run remove-pulp2 command after upgrading to 4.0 #1326
Conversation
|
Should this also run for luna? IMHO yes. And currently this will run remove after the upgrade to 3.18, which means it will purge katello (as it depends on pulp-selinux in 3.18). I guess it should check whether the intermediate/final version is 4.0 instead? |
ehelms
force-pushed
the
run-remove-pulp2
branch
2 times, most recently
from
b4bf3b4
to
9318183
Compare
Done |
| @@ -20,3 +20,11 @@ | |||
| scenario_version: "{{ forklift_upgrade_version_final }}" | |||
| - foreman_server_repositories | |||
| - foreman_installer | |||
| post_tasks: | |||
| - name: Run remove Pulp 2 | |||
| command: foreman-maintain content remove-pulp2 | |||
There was a problem hiding this comment.
i think this will stop and ask if you want to proceed, in retrospect we should have added a --force option
Maybe you force some input into it?
There was a problem hiding this comment.
Ahh yea, I see that here -- https://github.com/theforeman/foreman_maintain/pull/442/files#diff-69a7be004ceb14fd5a9c0c117906b77e5dc900604a03df595ae737d2484b9bfbR42
I will test a way around this to run it hands off.
There was a problem hiding this comment.
Should it be shell: yes | foreman-maintain content remove-pulp2 while we file an issue for a --yes or --force? (I feel like --force may be too strong for just a "do not ask for confirmation").
There was a problem hiding this comment.
Yeah, I too hate it when --force means --assume-yes (or similar).
There was a problem hiding this comment.
yes, i'd prefer --assume-yes, more meant a general option
ehelms
force-pushed
the
run-remove-pulp2
branch
from
9318183
to
6f93364
Compare
ehelms
force-pushed
the
run-remove-pulp2
branch
from
6f93364
to
430c957
Compare
| @@ -21,3 +21,11 @@ | |||
| - foreman_server_repositories | |||
| - role: foreman_installer | |||
| foreman_installer_skip_installer: "{{ true if forklift_upgrade_version_start == forklift_upgrade_version_intermediate else false }}" | |||
| post_tasks: | |||
| - name: Run remove Pulp 2 | |||
| shell: yes | foreman-maintain content remove-pulp2 | |||
There was a problem hiding this comment.
I've known about this pattern for a long time but I think this is the first time I see it in action :)
Given users are expected to run this at some point, and as we progress through the current Katello versions and those coming after,