Make forklift compatible with ansible-core #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Continuous Release repository provides RPMs before the full release is out. This is only done on CentOS 7, which is now in maintenance mode so we don't expect relevant changes. This removes the ini_file dependency, which is no longer in ansible-core.
ekohl
commented
Aug 2, 2022
| @@ -31,6 +31,16 @@ | |||
| - rubygem-deep_merge | |||
| state: 'present' | |||
|
|
|||
| - name: 'install telemetry system dependencies' | |||
There was a problem hiding this comment.
I'm not sure this is the right solution. Right now it's compiling the whole SDK which takes a few minutes. In CI we use wheels, so that's probably better.
|
I'd like to merge this now so we can at least move forward. |
ehelms
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to get our CI testing on CentOS CI to work with ansible-core.
Right now this is a draft, but I'll continue iterating on this until I get a complete run.