Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable sync folder for CI #1554

Merged
merged 2 commits into from Aug 9, 2022
Merged

disable sync folder for CI #1554

merged 2 commits into from Aug 9, 2022

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Aug 9, 2022

No description provided.

@evgeni evgeni force-pushed the no-rsync branch 2 times, most recently from c778905 to 743fcec Compare August 9, 2022 09:04
@ekohl
Copy link
Member

ekohl commented Aug 9, 2022

I thought it was weird that Rubocop passes on Ruby 3.1, but not on older versions. Then I saw this:

forklift/vagrant/Gemfile

Lines 14 to 18 in 0753db1

if RUBY_VERSION < '3.1'
# we need a rubocop that still can manage Ruby 2.0 code
# but 0.49.x is not compatible with Ruby 3.1
gem 'rubocop', '<0.50'
end

@evgeni evgeni merged commit aa0ace6 into theforeman:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants