Skip import/export tests if pulpcore 3.39 #1735
Conversation
|
I think the ostree ones were actually passing but failing silently. The export tests seemed to be the actual failure points https://ci.theforeman.org/blue/rest/organizations/jenkins/pipelines/katello-nightly-rpm-pipeline/runs/1838/log/?start=0 |
|
ack, moving around. I can probably go ahead and handle the .gz failures as well. what's the new extension? |
|
It's just .tar, rather than .tar.gz |
pcreech
force-pushed
the
skip-ostre-pulp339
branch
from
4aa3024
to
82ed6ce
Compare
|
Updated, added second commit switching .gz to .tar |
This will break for all releases using versions before 3.39, can we use |
|
Also, doesn't this disableall Export/Import tests? |
pcreech
changed the title
|
It does disable all, it appeared the issue was in a few. Is the suggestion to keep incremental in? |
|
Ah, I think I've read the original comment wrongly. The idea is to disable all import/export tests for 3.39 until that one Pulpcore big is fixed? |
| hammer content-export complete version --organization="${ORGANIZATION}" \ | ||
| --content-view="${CONTENT_VIEW}" --version="1.0" | ||
| export_version_id=$(hammer --output csv --no-headers content-view version show --version="1.0" --content-view="${CONTENT_VIEW}" --organization="${ORGANIZATION}" \ | ||
| --fields=id) | ||
| actual_size=$(du -k "$(hammer --output csv --no-headers content-export list --content-view-version-id=$export_version_id --fields="path")"/*.gz | cut -f 1) | ||
| actual_size=$(du -k "$(hammer --output csv --no-headers content-export list --content-view-version-id=$export_version_id --fields="path")"/*.tar | cut -f 1) | ||
|
|
||
| [ $actual_size -ge 40 ] |
There was a problem hiding this comment.
Not for this PR, but can we actually list the contents of the tar file and check that? It would also validate the resulting file(s) are actually valid tar files.
As for the rename: don't we need to keep the gzip bits for older Pulp versions?
There was a problem hiding this comment.
Based on evgeni's suggestion, and verifying with dalley that it is so, I've switched it to do ".tar*' to encapsulate gz without needing to resort to adding complexity with if/else logic
bats/foreman_helper.bash
Outdated
| @@ -28,6 +28,12 @@ tKatelloVersion() { | |||
| ) | cut -d. -f1-2 | |||
| } | |||
|
|
|||
| tSkipIfPulp39() { | |||
There was a problem hiding this comment.
| tSkipIfPulp39() { | |
| tSkipIfPulp339() { |
There was a problem hiding this comment.
Thanks Visual Studio Code! Or, more specifically, the need to save files in editors.... :D
There was a problem hiding this comment.
This should be fixed now. Ctl+s to the rescue!
pcreech
force-pushed
the
skip-ostre-pulp339
branch
from
ec829f3
to
6b737ec
Compare
No description provided.