Fixes #19663 - format foreman installer options as a list in the docs #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
approved these changes
May 30, 2017
docs/development.md
Outdated
| @@ -34,7 +34,11 @@ centos7-devel: | |||
| group: 'devel' | |||
| variables: | |||
| katello_devel_github_username: <REPLACE ME> | |||
| foreman_installer_options_internal_use_only: "--katello-devel-github-username myname --katello-devel-upstream-remote-name origin --katello-devel-extra-plugins theforeman/foreman_remote_execution --katello-devel-extra-plugins theforeman/foreman_discovery" | |||
| foreman_installer_options_internal_use_only: | |||
| - "--katello-devel-github-username <REPLACE ME>" | |||
There was a problem hiding this comment.
I wonder if you can use {{ katello_devel_github_username }} at this point.
There was a problem hiding this comment.
Probably we can, will test in a second. Thanks for the suggestion!
There was a problem hiding this comment.
Given we override the foreman_installer_options_internal_use_only variable it looks like katello_devel_github_username isn't used at all actually. This example can be simplified to get rid of it.
There was a problem hiding this comment.
I thought about that too. I prefer to use {{ katello_devel_github_username }} as that allows us to yank the foreman_installer_options_internal_use_only at a later point and still have the username set properly.
|
Thanks! |
johnpmitsch
pushed a commit
to johnpmitsch/forklift
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.